[Development] GitHub Pull requests

Zacruzin zacruzin at aol.com
Tue Mar 10 18:08:39 CET 2020

Please remove me from this email chain.Thank you!

-----Original Message-----
From: Konstantin Tokarev <annulen at yandex.ru>
To: Cristián Maureira-Fredes <cristian.maureira-fredes at qt.io>; development at qt-project.org <development at qt-project.org>
Sent: Tue, Mar 10, 2020 12:07 pm
Subject: Re: [Development] GitHub Pull requests

10.03.2020, 19:25, "Cristián Maureira-Fredes" <cristian.maureira-fredes at qt.io>:
> Hello,
> On 3/10/20 3:48 PM, Konstantin Tokarev wrote:
>>  I think, lowering barrier of entry at expense of reviewers' convenience should
>>  have its limits
> Totally agree,
> so we should plan to accept patches from platform and systems
> made for code development, like Github :)
> , otherwise we may end up accepting contributions from Twitter:)
> If Twitter becomes on a code development platform
> with pull-requests, reviews, and so on...sure :P

My point is that GitHub is inferior as a code review platform. Lowering entry barrier 
for drive-by contributors (who quite likely won't come back to maintain code they've
introduced), it reduces quality of life for reviewers.


Development mailing list
Development at qt-project.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20200310/de09ab50/attachment.html>

More information about the Development mailing list