[Development] Debian packaging from Git snapshots (qtsystems, qtfeedback, qtpim)
Chris Adams
chris.adams at qinetic.com.au
Tue Mar 31 02:12:21 CEST 2020
Hi Mike,
On Tue, Mar 31, 2020 at 12:29 AM Mike Gabriel <
mike.gabriel at das-netzwerkteam.de> wrote:
> Hi Chris,
>
> On Di 17 Mär 2020 01:42:11 CET, Chris Adams wrote:
>
> >> [...]
> >
> > Potentially. The licensing of QtPIM only changed recently (in terms of
> > changes), and Jolla's fork of QtPIM remains LGPLv2.1, so IMO if the
> > upstream were to change, I think taking that version might be a sensible
> > option, as it might attract more contributors / maintainers from
> commercial
> > side (and developer capacity is currently the bottleneck for improvement,
> > IMO).
> > Of course, that would be an option of last resort, in my opinion.
> >
>
> I have nearly finished the upload preparations of QtPIM for Debian. I
> have some questions about patches originally coming from the former
> Ubuntu Touch project.
>
> Most of Canonical's patches have been upstreamed (or they were
> cherry-picked from upstream). However, there is one patch that either
> still needs upstreaming or should be dropped from the proposed package:
>
> https://salsa.debian.org/qt-kde-team/qt/qtpim/-/blob/master/debian/patches/Avoid-crash-while-parsing-vcards-from-different-threads.patch
>
> Unfortunately, it is unclear who the original patch author is and what
> the exact bug is that gets fixed by the patch (I mean, the patch name
> itself is informative a bit, but apart from that, not much context is
> available).
>
I am not sure, however I notice that Renato Araujo Oliveira Filho has some
thread-safety related commit in the history. Alberto and Renato would be
the most likely candidates.
> Furthermore, I had to disable 5 unit tests at 3 different locations to
> get the package pass through the other tests:
>
> https://salsa.debian.org/qt-kde-team/qt/qtpim/-/blob/master/debian/patches/disable_failing_tests.patch
Curious, seems like a case sensitive string collation issue. I don't
believe they were failing previously, but perhaps it's locale-specific (or
ICU version specific, or something).
> As a side not, I noticed in qtsystems, qtfeedback and qtpim alike that
> the cmake tests entirely fail during chrooted builds with a defined
> DESTDIR (i.e. packages are installed into some subfolder from where
> the binary packages get wrapped up). But that was not so important, so
> I disabled cmake integration tests entirely for all three packages.
>
I haven't yet managed to find the time to fix even building with qtdev as
yet, let alone look into the cmake tests. I was hoping to do so earlier
this month, but it was not to be, unfortunately.
Cheers,
Chris.
>
> Looking forward to your feedback,
> Mike
>
>
> --
>
> DAS-NETZWERKTEAM
> c\o Technik- und Ökologiezentrum Eckernförde
> Mike Gabriel, Marienthaler str. 17, 24340 Eckernförde
> mobile: +49 (1520) 1976 148
> landline: +49 (4351) 850 8940
>
> GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31
> mail: mike.gabriel at das-netzwerkteam.de, http://das-netzwerkteam.de
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20200331/69dd551e/attachment.html>
More information about the Development
mailing list