[Development] Version-controlling the SVGs of built-in icons

[Mitch Curtis]

> -----Original Message-----
> From: Development <development-bounces at qt-project.org> On Behalf Of
> Volker Hilsheimer
> Sent: Friday, 18 June 2021 11:20 AM
> To: development at qt-project.org
> Subject: [Development] Version-controlling the SVGs of built-in icons
> 
> Hi,
> 
> 
> The majority of time spent on QTBUG-38776 is chasing down the various
> SVGs from which it’s then trivial to generate PNGs in different resolutions.
> 
> Which makes me think that we should have those SVGs version controlled
> somewhere. That “somewhere” can either be the respective module
> repositories, or a dedicated repo with all SVGs. I’m in favour of the latter
> option, mostly because it makes it easier for the digital artists who create and
> maintain those SVGs to do that without having to clone the world and
> navigate a rather complex repo and file system structure. But there are pros
> and cons to either approach.
> 
> Since that might become the place for scalable versions of all icons, including
> those for Qt Creator and Qt Design Studio, having such a repo under the “qt"
> namespace seems odd. But I don’t see any obviously better option either.
> 
> Any opinions?

Hi Volker.

I've been adding source SVGs for PNG icons in the module itself in the case of qtquickcontrols2:

mitch at mitch-ubuntu-20:~/dev/qt-dev/qtquickcontrols2$ find . -name "*svg"
./tests/auto/qquickiconimage/icons/testtheme/appointment-new.svg
./examples/quickcontrols2/wearable/qml/Settings/images/theme.svg
./examples/quickcontrols2/wearable/qml/Settings/images/demo-mode.svg
./examples/quickcontrols2/imagine/automotive/icons/automotive/icons.svg
./examples/quickcontrols2/imagine/musicplayer/icons/musicplayer/icons.svg
./src/quickdialogs2/quickdialogs2quickimpl/images/up-icon-thick-square.svg
./src/quickdialogs2/quickdialogs2quickimpl/images/crumb-separator-icon-round.svg
./src/quickdialogs2/quickdialogs2quickimpl/images/file-icon-round.svg
./src/quickdialogs2/quickdialogs2quickimpl/images/up-icon-square.svg
./src/quickdialogs2/quickdialogs2quickimpl/images/folder-icon-square.svg
./src/quickdialogs2/quickdialogs2quickimpl/images/file-icon-square.svg
./src/quickdialogs2/quickdialogs2quickimpl/images/up-icon-round.svg
./src/quickdialogs2/quickdialogs2quickimpl/images/imagine/filedialogdelegate-background.svg
./src/quickdialogs2/quickdialogs2quickimpl/images/crumb-separator-icon-square.svg
./src/quickdialogs2/quickdialogs2quickimpl/images/folder-icon-round.svg
./src/quickcontrols2/material/images/drop-indicator.svg
./src/quickcontrols2/material/images/arrow-indicator.svg
./src/quickcontrols2/doc/images/qtquickcontrols2-control.svg
./src/quickcontrols2/doc/images/qtquickcontrols2-popup.svg
./src/quickcontrols2/fusion/images/arrow.svg
./src/quickcontrols2/fusion/images/progressmask.svg
./src/quickcontrols2/fusion/images/checkmark.svg

I would vote for keeping the icons in the modules where they're used. Ideally that would be next to the generated images, as that makes it easy to find them and is an easy convention to follow.

I'm not sure how many designers use Git to be honest. Most of my interactions with designers have involved exchanging files through email/chat/file hosting. If they are using Git though, I wouldn't think it would matter too much where the files are, because that still needs to be communicated up front before the work begins.

Cheers.

> 
> Volker
> 
> 
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> https://lists.qt-project.org/listinfo/development