[Development] 回复: Asking for a FF exception for ICU based QStringConverter

[Zhang JiDe]

This case is very complicated. In actual we often expect to get an app_compile_version with the smallest version number. In the above case, it should be 6.3, but the existing code cannot do it. If we have a better way then we can rewrite it, but the current implementation should be removed anyway, I approve this patch.


________________________________
发件人: Development <development-bounces at qt-project.org> 代表 Thiago Macieira <thiago.macieira at intel.com>
发送时间: 2022年6月9日 19:47
收件人: development at qt-project.org <development at qt-project.org>
主题: Re: [Development] Asking for a FF exception for ICU based QStringConverter

On Thursday, 9 June 2022 12:36:25 PDT Alexander Akulich wrote:
> On Thu, Jun 9, 2022 at 10:14 PM Thiago Macieira
>
> <thiago.macieira at intel.com> wrote:
> > Doesn't work for libraries.
>
> Can you explain please?

Libraries don't call QCoreApplication's constructor.

The application may have been recompiled and thus will inform QCoreApplication
it was compiled against 6.4, but the library in question (a KF6 one) may have
still been compiled against 6.3.

> I see this correspond to 5.0.0 until
> QCoreApplication constructor called but I thought it would be 'better
> than a leak'.
> QCoreApplicationPrivate::app_compile_version is a part of QtCore, so
> even if it won't work *across* the libraries, it is still available
> for QStringConverter because it is a part of the same library.

Wrong tool for the job, as explained above. Removing in:
https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcodereview.qt-project.org%2Fc%2Fqt%2Fqtbase%2F%2B%2F415327&data=05%7C01%7C%7C5af22458930f41226e9a08da4a5123a4%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637904009592072578%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=UgJ2X9hDA5QAYd9EyX8kERS4TQFj6vTZaiOa%2BfQ2AVo%3D&reserved=0

In any case, I'll not make a runtime decision based on version. It's much
easier to make a static decision based on which function you called.

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Cloud Software Architect - Intel DCAI Cloud Engineering



_______________________________________________
Development mailing list
Development at qt-project.org
https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.qt-project.org%2Flistinfo%2Fdevelopment&data=05%7C01%7C%7C5af22458930f41226e9a08da4a5123a4%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637904009592072578%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=NOo%2BrXSDc%2BMs6xScq9tiF6T2ocJRxeta7l6ecw3Y5CY%3D&reserved=0
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20220610/5c8745ad/attachment-0001.htm>