[Development] Proposals for changes to "Precheck" feature

[Thiago Macieira]

On Friday, 25 March 2022 13:42:39 -03 Volker Hilsheimer wrote:
> * always rebase the commit before prechecking
> 
> Right now, precheck is a checkout, which means that the precheck is done on
> top of the revision that it was pushed from. Since that is not the revision
> that it will ultimately integrate against, this makes the precheck less
> accurate. And it also ends up wasting CI resources if the precheck is done
> for a leaf repo, with a revision that might have ancient dependencies. Then
> qtbase etc from those dependency revisions might need to be rebuilt if they
> are not in the artefact cache anymore.

That's good... except when it isn't.

When you have multiple changes you've submitted, you could pre-check the last 
one and get a result for all of them. That use-case will go away with 
rebasing.

But that was already pretty limited. If you updated any of the previous 
changes, the pre-check would no longer work.

I've resorted to pushing a dummy, WIP change with no reviewers and all my 
changes squashed, so I could pre-check that. In that case, I could rebase it 
at will too.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel DPG Cloud Engineering