[Development] Can't get review for more than two years

[Ilya Fedin]

On Thu, 29 Jun 2023 08:36:51 +0000
Axel Spoerl via Development <development at qt-project.org> wrote:

> Hi Ilya,
> I had a look at the patch and commented it.
> IMHO it raises a valid point, but it can't be landed like this.
> Suggest to file a suggestion in https://bugreports.qt.io, to document
> in more detail what this is about. Cheers
> Axel
> ________________________________
> Von: Development <development-bounces at qt-project.org> im Auftrag von
> Ilya Fedin <fedin-ilja2010 at ya.ru> Gesendet: Donnerstag, 29. Juni 2023
> 00:43 An: development at qt-project.org <development at qt-project.org>
> Betreff: Re: [Development] Can't get review for more than two years
> 
> On Wed, 28 Jun 2023 19:21:30 -0300
> Lisandro Damián Nicanor Pérez Meyer <perezmeyer at gmail.com> wrote:
> 
> > Hi,
> >
> > On Tue, 20 Jun 2023 at 02:41, Ilya Fedin <fedin-ilja2010 at ya.ru>
> > wrote:  
> > >
> > > Hi,
> > >
> > > I have a change[1] I made two years ago. People were adding
> > > another people to reviewers as no one of them had knowledge to
> > > review the change. Since some time people has just started
> > > ignoring pings. More than two years has passed but the change is
> > > still there, with no votes nor clear explanation of what blocks
> > > it. It's the most terrible contributing experience I've ever had.
> > >
> > > [1] https://codereview.qt-project.org/c/qt/qtbase/+/343628  
> >
> > The patch you proposed has comments and NACKs.
> >
> > I'll add more info: the problem you are trying to solve **might** be
> > easily solved by installing xdg-desktop-portal and/or some other
> > portal like the gtk and kde ones.
> >
> > My 2c, Lisandro
> >
> >  
> 
> They were added thanks to this e-mail yet discussion has stopped even
> though I've answered to those NACKs (which are based on false
> assumptions)
> 
> I already have xdg-desktop-portal installed, Qt doesn't read font
> settings from it (and it shouldn't really use portals for that on X11,
> that's relevant only for Wayland).
> --
> Development mailing list
> Development at qt-project.org
> https://lists.qt-project.org/listinfo/development

Well, QTBUG-43745 perfectly explains what this is about: Qt doesn't
read font settings from the right place on a lot of DEs like MATE,
Cinnamon and Pantheon. I think maintaining a hardcoded list of gtk DEs
is unreliable approach, it also fails with platformtheme detection for
Pantheon (QTBUG-52292). gtk DEs seem to appear and disappear faster
than Qt becomes aware of them.

Given that it works without such a hardcoded list (and even doesn't
harm KDE and other Qt DEs), I think it's better to make it work without
a hardcoded list.

And even when the hardcoded list hits the match, it still prefers
fontconfig what means if the distro has a fontconfig for hinting and
etc, it will be preferred instead of settings the user made in the DE
UI (since those DEs don't touch fontconfig) with the current code and
that's also what my patch fixes.