[Development] Can't get review for more than two years

Axel Spoerl axel.spoerl at qt.io
Thu Jun 29 10:36:51 CEST 2023


Hi Ilya,
I had a look at the patch and commented it.
IMHO it raises a valid point, but it can't be landed like this.
Suggest to file a suggestion in https://bugreports.qt.io, to document in more detail what this is about.
Cheers
Axel
________________________________
Von: Development <development-bounces at qt-project.org> im Auftrag von Ilya Fedin <fedin-ilja2010 at ya.ru>
Gesendet: Donnerstag, 29. Juni 2023 00:43
An: development at qt-project.org <development at qt-project.org>
Betreff: Re: [Development] Can't get review for more than two years

On Wed, 28 Jun 2023 19:21:30 -0300
Lisandro Damián Nicanor Pérez Meyer <perezmeyer at gmail.com> wrote:

> Hi,
>
> On Tue, 20 Jun 2023 at 02:41, Ilya Fedin <fedin-ilja2010 at ya.ru> wrote:
> >
> > Hi,
> >
> > I have a change[1] I made two years ago. People were adding another
> > people to reviewers as no one of them had knowledge to review the
> > change. Since some time people has just started ignoring pings. More
> > than two years has passed but the change is still there, with no
> > votes nor clear explanation of what blocks it. It's the most
> > terrible contributing experience I've ever had.
> >
> > [1] https://codereview.qt-project.org/c/qt/qtbase/+/343628
>
> The patch you proposed has comments and NACKs.
>
> I'll add more info: the problem you are trying to solve **might** be
> easily solved by installing xdg-desktop-portal and/or some other
> portal like the gtk and kde ones.
>
> My 2c, Lisandro
>
>

They were added thanks to this e-mail yet discussion has stopped even
though I've answered to those NACKs (which are based on false
assumptions)

I already have xdg-desktop-portal installed, Qt doesn't read font
settings from it (and it shouldn't really use portals for that on X11,
that's relevant only for Wayland).
--
Development mailing list
Development at qt-project.org
https://lists.qt-project.org/listinfo/development
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20230629/3b2ac598/attachment.htm>


More information about the Development mailing list