[Development] Trouble getting reviews in months and years

Ilya Fedin fedin-ilja2010 at ya.ru
Tue Apr 9 06:05:11 CEST 2024


В Mon, 08 Apr 2024 22:36:56 -0500
Thiago Macieira <thiago.macieira at intel.com> пишет:

> On Monday 8 April 2024 17:17:04 CDT Ilya Fedin wrote:
> > 2. https://codereview.qt-project.org/c/qt/qtbase/+/444859 which is
> > 1.5 years old and no review  
> 
> Submitted during Christmas break and no changes since New Years. No
> wonder it was missed. You should have sent a "ping" during the second
> week of January.
> 
> That's the rule of thumb: after a week with no reviews, send "ping> .
> One week later, "re-ping". If you reach the third week, explicitly
> add the maintainer of the module in question and say, "maintainer, do
> your duty and review". And if that maintainer is unavailable for some
> reason, add Volker.
> 
> If all else fails, there's this mailing list. You can send an email
> with your pending reviews and request that they be reviewed. But
> advice: include the topic of the review, not just the link and how
> long it's been. I have absolutely no clue on reviewing XCB stuff, but
> I had to click every link to make sure none of them was a QtCore
> issue I might have missed.
> 

Well, I pinged lots of time in other changes as you can see... This
never worked for me so I thought it won't work this time as well.
It also seemed like there's enough amount of changes and enough time has
passed to write to mailing list...


More information about the Development mailing list