[Development] Trouble getting reviews in months and years

[Lorn Potter]

Hi-

On 8/10/24 09:41, Ilya Fedin wrote:
> Well, I told my experience. I was also asking another person who
> is trying to contribute Qt, too, about his expereince, he said he also
> can't get reviews in reasonable times. IIRC he has has too around 10
> open changes and most of them are open for a long time.


I feel your pain. But you know what? It's always like that sometimes. 
I've worked on and around Qt for 20 years, and it's always been like 
that! - internally and externally. Other open source projects are the 
same. You might have to ping people on the mailing list, 2, 3 times, or 
one of the several developer chat places like discord and irc. 
Developers are often busy with their own things.

It happens to me heaps, but I am partially to blame, as I am the 
developer trying to get changes into a huge code base. Not every 
reviewer will know a lot about the bug or code/module being fixed, as 
well. Especially something like X11 code that goes way back.

Ya just gotta keep trying. If someone disagrees with the premise you 
either have to just drop it, explain things better with more detail, or 
go back and work on the bug fix more.


-

Lorn