[Interest] Standard QKeySequence for "Fullscreen" (was: Contributor agreement rundown)

Till Oliver Knoll till.oliver.knoll at gmail.com
Fri Apr 20 19:37:15 CEST 2012



Am 20.04.2012 um 18:30 schrieb Rick Stockton <rickstockton at reno-computerhelp.com>:

> On 04/20/2012 02:33 AM, Till Oliver Knoll wrote:
> 
> << short Snip >>
>> .... a standard key sequence for "Fullscreen" is still missing.
>> 
>>   Apple says "Control+Command+F":
>>    ...
>>  - the standard keys should also consider user settings
>> which might have changed these standard keys, for example to be
>> evaluated upon application initialisation. The "premium solution"
>> would get notified of user setting changes and change the shortcuts at
>> runtime :)
> Too difficult for me. And that would be a lot of new API, as well. I 
> won't be going there, sorry.

Okay, forget about the "changing at runtime if the user decided to change some OS settings". Restarting the application would be totally acceptable.

However evaluating the "OS / desktop manager settings" would be useful and require absolutely /no/ new *public* APIs.

Qt would check "upon initialisation" if there were any "user setting overrides" (that part is off course dependend on all kinds of factors: OS, OS version, desktop manager, ...), and if so, take them to initialise the "standard QKeySequence values". If no such setting available, use the standard shortcuts, as indicated by the platform guidelines mentioned previously.

No API changes at all for Qt applications. The only visible change you would see is you'd get a different shortcut, if specified so by the user (which is what you want).

> I won't be inclined to "enhance" 4.8.x. (In my thinking, this is not a 
> bugfix.) But it looks really easy to add the 4 'platform standard' 
> shortcuts as new QKeySequence and QShortcut instances. QWindow already 
> provides the signal-receiving Slot.

To be clear: I am really only talking about an additional standard QKeySequence here (which happens to be for "Fullscreen"). And when it comes to Qt 5 also with "user settings awareness".

So if you mention slots in QWindow (I guess you refer to the fullscreen slot) you're probably already going beyond of what I was talking. ;)

> ...
> and I'm even LESS comfortable with adding a two-fingered, F11-based 
> QKeySequence to the Apple/Cocoa platform, because Apple has reserved F11 
> for their own use.

No one suggested to use F11 (or any combination with it) on OS X. See previous posts ;)

> This would not be an API change, but would create new documentation. 
> Thiago, is this acceptable as a post-Beta change, or should it wait for 
> 5.1?

Hey, what about adding it to 4.8.x (without the "user setting awareness" part, off course)? Its just an additional field to document ;)

Cheers, Oliver





More information about the Interest mailing list