[PySide] Call for help: regression bugs to be fixed

[Andy Kittner]

On Tue, Feb 28, 2012 at 06:02:16PM +0200, Matti Airas wrote:
>> Anyway, some of them are really trivial (just read the description and
>> follow the suggested fix, if any). Good for new contributors :)
>
>Indeed, most of them are actually one-liners with just small syntactic
>changes!

I could probably also do at least some of them.
Since I never worked with gerrit before I looked around a bit and found:

   http://wiki.qt-project.org/Gerrit_Introduction
   http://wiki.qt-project.org/Setting_up_Gerrit

I guess they apply to PySide as well (including the mentioned 
commit-hooks?)

If I understood everything correctly essentially I would need to:
  - clone the repository
  - set up the hooks
  - make the change
  - push the change back to the master
?
Anything else I need to consider?


Secondly I think some merge in the shiboken repository went wrong.
The following files are in the repository:
   libshiboken/basewrapper.cpp.orig
   libshiboken/basewrapper_p.h.orig

And the build fails because ParentInfo::children is not consistently
used as a std::list.

Using either the .orig files, or a list-iterator appears to work:

diff --git a/libshiboken/basewrapper.cpp b/libshiboken/basewrapper.cpp
index d60d301..b5156b9 100644
--- a/libshiboken/basewrapper.cpp
+++ b/libshiboken/basewrapper.cpp
@@ -115,7 +115,7 @@ static int SbkObject_traverse(PyObject* self, visitproc visit, void* arg)
     //Visit children
     Shiboken::ParentInfo* pInfo = sbkSelf->d->parentInfo;
     if (pInfo) {
-        std::set<SbkObject*>::const_iterator it = pInfo->children.begin();
+        std::list<SbkObject*>::const_iterator it = pInfo->children.begin();
         for(; it != pInfo->children.end(); ++it)
             Py_VISIT(*it);
     }




Regards,
Andy
-- 
All's well that ends.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.qt-project.org/pipermail/pyside/attachments/20120228/0b17ee86/attachment.sig>