[PySide] Call for help: regression bugs to be fixed

Matti Airas matti.p.airas at nokia.com
Wed Feb 29 11:23:40 CET 2012

On 28.02.2012 20:40, ext Andy Kittner wrote:
> I could probably also do at least some of them.

Great! :-)

> Since I never worked with gerrit before I looked around a bit and found:
>   http://wiki.qt-project.org/Gerrit_Introduction
>   http://wiki.qt-project.org/Setting_up_Gerrit
> I guess they apply to PySide as well (including the mentioned 
> commit-hooks?)

Yes, these instructions apply to PySide as well.

> If I understood everything correctly essentially I would need to:
>  - clone the repository
>  - set up the hooks
>  - make the change
>  - push the change back to the master
> ?
> Anything else I need to consider?

The push needs to be for the refs/for/master as the target ref. And 
after this, you need to either notify some reviewers about the new 
contribution (using this mailing list or the IRC channel) or manually 
add reviewers using the Gerrit web interface. Then, the patches can be 
reviewed and hopefully approved.

> Secondly I think some merge in the shiboken repository went wrong.
> The following files are in the repository:
>   libshiboken/basewrapper.cpp.orig
>   libshiboken/basewrapper_p.h.orig

OK, this is awkward. Don't know what happened but I had managed to leave 
these in the working set when flattening the repos. I've fixed the issue 
in my clone and requested the Qt admins to force push the fixed commit in.

Thanks a lot for the heads up!

> And the build fails because ParentInfo::children is not consistently
> used as a std::list.

OK, my bad as well. I only did minimal reverts to the offending commits 
and did not test whether the code compiles after that. On the other 
hand, this approach should save a few edits when reimplementing the set 
use. :-)



More information about the PySide mailing list