[Qt-creator] Perforce VCS: top level directory detection

[Ziller Eike]

On 26.09.2013, at 08:37, hatred <adrozdoff at gmail.com>
 wrote:

> Uhhh.. Its not very trivial but I create code review: https://codereview.qt-project.org/#change,66573 :-)
> 
> Also, I forget rebase my changes into one commit and create two wrong reviews:
> https://codereview.qt-project.org/#change,66570
> https://codereview.qt-project.org/#change,66571
> 
> Is it possible to destroy them?

There's a "Abandon Change" button near the "Review" and "Submit" buttons.

Br, Eike


> 
> 
> 2013/9/10 Orgad Shaneh <orgads at gmail.com>
> On Tue, Sep 10, 2013 at 11:52 AM, hatred <adrozdoff at gmail.com> wrote:
> Hi Tobias,
> 
> Heh... I don't have access to the global git repos via ssh & git protocols, so I can't clone repo from codereview.qt-project.org :-( Can code review tool assept changes via e-mail (git format-patch ..., git send-email)?
> 
> 
> 2013/9/10 Tobias Hunger <tobias.hunger at gmail.com>
> 
> On Sep 10, 2013 8:48 AM, "hatred" <adrozdoff at gmail.com> wrote:
> > So I prepare patch that helps me to work with perforce and fix top-level directory detection issue: http://pastebin.com/TE8Vey54
> 
> Hey, thanks for investigating!
> 
> Unfortunately I can only accept contributions that are sent in via https://codereview.qt-project.org/
> 
> I would appreciate if you could go through the setup there and send the patch via the review system.
> 
> Thanks!
> 
> > I also attach it to this letter.
> >
> > This patch based on the latest 2.8 branch (2013-09-10).
> >
> > Can any body create issue on tracker and attach this patch?
> 
> No, for this patch to get accepted you have to push it into codereview (aka credit). We may not use the code otherwise.
> 
> Best Regards,
> Tobias
> 
> 
> 
> _______________________________________________
> Qt-creator mailing list
> Qt-creator at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/qt-creator
> 
> 
> Try using ssh.qt-project.org. See here.
> 
> - Orgad
> 
> _______________________________________________
> Qt-creator mailing list
> Qt-creator at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/qt-creator

-- 
Eike Ziller, Senior Software Engineer - Digia, Qt
 
Digia Germany GmbH, Rudower Chaussee 13, D-12489 Berlin
Geschäftsführer: Mika Pälsi, Juha Varelius, Anja Wasenius
Sitz der Gesellschaft: Berlin, Registergericht: Amtsgericht Charlottenburg, HRB 144331 B