[Qt-creator] Gerrit disapproval messages

Cristian Tibirna tibirna at kde.org
Sun Jan 26 22:13:05 CET 2014


On Sunday 26 January 2014 10:06:37 Orgad Shaneh wrote:
> Hi,
> 
> Following this
> discussion<http://lists.qt-project.org/pipermail/qt-creator/2012-December/0
> 01718.html>from about a year ago,
> 
> gerrit has recently accepted a wording
> change<https://gerrit-review.googlesource.com/54000>for default -1 and
> -2 Code-Review labels.
> 
> The scores are now:
> -1 - I would prefer this is not merged as is
> -2 - This shall not be merged
> 
> I suggest configuring qt-project gerrit to something similar.
> 
> Opinions?

Strongly agree: 
http://lists.qt-project.org/pipermail/qt-creator/2012-December/001718.html

As Guido observes, this is still not ideal, but it is much better than the 
current.

-- 
Cristian



More information about the Qt-creator mailing list