[Qt-creator] Gerrit disapproval messages

[Coda Highland]

On Sun, Jan 26, 2014 at 1:13 PM, Cristian Tibirna <tibirna at kde.org> wrote:
> On Sunday 26 January 2014 10:06:37 Orgad Shaneh wrote:
>> Hi,
>>
>> Following this
>> discussion<http://lists.qt-project.org/pipermail/qt-creator/2012-December/0
>> 01718.html>from about a year ago,
>>
>> gerrit has recently accepted a wording
>> change<https://gerrit-review.googlesource.com/54000>for default -1 and
>> -2 Code-Review labels.
>>
>> The scores are now:
>> -1 - I would prefer this is not merged as is
>> -2 - This shall not be merged
>>
>> I suggest configuring qt-project gerrit to something similar.
>>
>> Opinions?
>
> Strongly agree:
> http://lists.qt-project.org/pipermail/qt-creator/2012-December/001718.html
>
> As Guido observes, this is still not ideal, but it is much better than the
> current.

Like the suggestion in the first post of the old thread, I am of the
opinion that the message should speak somewhat more to a generic means
of resolution:

"I feel that this requires additional work before it is merged."

This is non-offensive, sounds subjective instead of authoritative,
avoids "you"-language, and clearly indicates that it's still possible
to be included -- just not like it is.

/s/ Adam