[Qt-creator] Preparing to contribute Boost.Build Plugin to Qt Creator
Mateusz Loskot
mateusz at loskot.net
Thu Apr 16 10:46:16 CEST 2015
On 15 April 2015 at 09:15, Orgad Shaneh <orgads at gmail.com> wrote:
> On Wed, Apr 15, 2015 at 9:58 AM, Mateusz Loskot <mateusz at loskot.net> wrote:
>> On 15 April 2015 at 08:46, André Hartmann <andre.hartmann at iseg-hv.de> wrote:
>> >> For example, let's assume we start working on the contribution as
>> >> follows:
>> >> 1. Import current sources of our plugin into
>> >> wip/boostbuildprojectmanager
>> >
>> > To submit this first commit, it would be best all current developers
>> > give a
>> > +1 review to show their acceptance that the code is merged to the Qt
>> > repositories.
>>
>> André,
>>
>> The issue here is, that I know the current code will be rejected straight away
>> due to Qt(Creator)-incompatible coding conventions used.
>> So, we need to port to Qt coding style and we will be working on it as a team.
>
>
> It won't be rejected. Wip branches are exactly for that - submitting changes
> that are unacceptable under regular terms
That's an important piece of clarification for me, indeed.
Best regards,
--
Mateusz Loskot, http://mateusz.loskot.net
More information about the Qt-creator
mailing list