[Qt-creator] Pretty old changes on gerrit

[André Hartmann]

Hi Jochen,

 > there are quite a number of very old changes on gerrit's master which
 > past the sanity bot review but never got a human review. Would it help
 > reviewing those changes starting with the oldest one?

For sure! If the changes are old, it may be better to ask the author 
first if they are still relevant.

 > May I add myself as reviewer to changes?

Yes. I do that too, if I have time, I am interested in the change and 
find something to comment on.

 > Of course there is the coding style but should a reviewer also run
 > tests with the reviewed code?

 > Should changes be built with qmake and qbs always?

Please read the following, it's not Qt specific but in general useful:

http://gerrit-training.scmforge.com/target/gerrit-and-code-review-best-practices/

To summarize possible review steps:

1. Read the code and look for style and logic errors
2. Suggest improvements
3. Cherry-pick the change to your local repo,
    does it apply without merge conflicts?
4. Compile the change, are there warnings or errors
5. Test the change

As Qt is cross-platform, 4 and 5 may work on one platform, but fail on 
an other. So every tester is welcome.

Best regards,
André

Am 04.06.2015 um 23:37 schrieb Jochen Becher:
> Hello,
>
> there are quite a number of very old changes on gerrit's master which
> past the sanity bot review but never got a human review. Would it help
> reviewing those changes starting with the oldest one?
>
> As I hope to publish my ModelEditor plugin in the next days and hope to
> for reviews soon I am willing to help with other reviews of course. May
> I add myself as reviewer to changes?
>
> I couldn't find documentation about expectations on reviews. Of course
> there is the coding style but should a reviewer also run tests with the
> reviewed code? What about documentation? Is this always reviewed by
> Leena? Should changes be built with qmake and qbs always?
>
> Regards, Jochen
>
>
> _______________________________________________
> Qt-creator mailing list
> Qt-creator at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/qt-creator
>


-- 
Best regards / Mit freundlichen Grüßen
André Hartmann, Dipl.-Ing. (FH)
Software Project Manager

iseg Spezialelektronik GmbH         |  phone: ++49 (0)351 26996-43
Bautzner Landstr. 23                |  fax:   ++49 (0)351 26996-21
D-01454 Radeberg / Rossendorf       |  web:   www.iseg-hv.com

Geschäftsführer / Managing director: Dr. F. Gleisberg, Dr. J. Pöthig
Amtsgericht / Lower district court: Dresden HRB 16250
Ust.-Id.-Nr. / VAT-ID: DE812508942

Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte
Informationen. Wenn Sie nicht der richtige Adressat sind oder
diese E-Mail irrtümlich erhalten haben, informieren Sie bitte
sofort den Absender und vernichten Sie diese Mail.
Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser
Mail ist nicht gestattet.

This e-mail may contain confidential and/or privileged information.
If you are not the intended recipient (or have received this e-mail
in error) please notify the sender immediately and delete this e-mail.
Any unauthorized copying, disclosure or distribution of the material
in this e-mail is strictly forbidden.