[Qt-creator] Closing pinned files

[David Schulz]

|-----Original Message-----
|From: EXT Mitch Curtis <mitch.curtis at qt.io>
|Sent: Tuesday, October 25, 2022 7:24 AM
|To: David Schulz <David.Schulz at qt.io>; qt-creator at qt-project.org
|Subject: RE: [Qt-creator] Closing pinned files
|
|> -----Original Message-----
|> From: Qt-creator <qt-creator-bounces at qt-project.org> On Behalf Of
|> David Schulz via Qt-creator
|> Sent: Tuesday, 25 October 2022 1:07 PM
|> To: qt-creator at qt-project.org
|> Subject: Re: [Qt-creator] Closing pinned files
|>
|> Hi,
|>
|> +2 for the general Idea that those files should not be closed by a shortcut.
|>
|> What do you think about replacing the closing button in a pinned
|> editor toolbar with an unpin button.
|> In this case you could briefly highlight this button when the closing
|> shortcut is pressed to inform the user that the action was not executed.
|> Another benefits would be that you have to press the button twice to
|> close the File with the mouse(first unpin than close), and we would
|> have a visual representation of that information when the open
|> documents pane is not visible.
|
|Ooo, I like that idea!
|
|Is there already code to highlight a widget in Creator?

If I remember correctly, we highlight the '#' button in the editor toolbar when you have additional preprocessor directives defined in a c++ editor, so you might steal code from that widget.

|
|> Greetings,
|> David
|>
|>
|> |-----Original Message-----
|> |From: Qt-creator <qt-creator-bounces at qt-project.org> On Behalf Of EXT
|> |Mitch Curtis via Qt-creator
|> |Sent: Monday, October 24, 2022 3:28 AM
|> |To: André Hartmann <aha_1980 at gmx.de>; qt-creator at qt-project.org
|> |Subject: Re: [Qt-creator] Closing pinned files
|> |
|> |Hi Andre,
|> |
|> |Thanks for the feedback.
|> |
|> |> -----Original Message-----
|> |> From: André Hartmann <aha_1980 at gmx.de>
|> |> Sent: Friday, 21 October 2022 11:10 PM
|> |> To: EXT Mitch Curtis <mitch.curtis at qt.io>;
|> |> qt-creator at qt-project.org
|> |> Subject: Re: [Qt-creator] Closing pinned files
|> |>
|> |> Hi Mitch,
|> |>
|> |> first of all, I'm no user of this feature, so I had to google it first.
|> |> But let me add my opinion:
|> |>
|> |> Seeing the motivation for the feature - to keep files in the Open
|> |> Documents list and in the Locator - leads to the question:
|> |>
|> |> Do you really want to forbid to actually close the split containing
|> |> the file, or do you just want to keep the file name in the Open
|> |> Documents
|> |list?
|> |
|> |The idea is to avoid accidentally closing the pinned file via
|> |shortcuts. So not necessarily about forbidding closing it, but
|> |ensuring that it doesn't leave the open documents list.
|> |
|> |> If the latter is sufficient, then no user question is needed.
|> |
|> |What should happen if the pinned file is the only one open in that
|> |case? Can a document be in the open documents list if it's not
|> |actually open
|> in an editor?
|> |
|> |> If the split should indeed actually stay open, I'd prefer a yellow
|> |> info box at the document top:
|> |>
|> |>    "File is pinned, unpin to close" [Unpin & Close] [X]
|> |>
|> |> as this is the least intrusive way (I really don't like messageboxes).
|> |
|> |Oh, good point, I'd forgotten about that banner thing.
|> |
|> |> Another possibility would be to keep the file/split open but show
|> |> the next file in the list, until all unpinned files are closed.
|> |
|> |That could be an option, but it seems confusing when I imagine it in
|practice.
|> |
|> |What would happen when only pinned files are left?
|> |
|> |> But the point I'm with you: pinned files should not close without
|> |> confirmation, and therefore I don't think a global setting allowing
|> |> that is useful.
|> |
|> |Good to know, thanks.
|> |
|> |> Best regards,
|> |> André
|> |>
|> |> Am 21.10.22 um 11:45 schrieb EXT Mitch Curtis via Qt-creator:
|> |> > … and Close All will be unaffected by this change; it just won’t
|> |> > do anything, as before, as it’d be too disruptive.
|> |> >
|> |> > *From:*Qt-creator <qt-creator-bounces at qt-project.org> *On Behalf
|> Of
|> |> > *EXT Mitch Curtis via Qt-creator
|> |> > *Sent:* Friday, 21 October 2022 5:43 PM
|> |> > *To:* qt-creator at qt-project.org
|> |> > *Subject:* [Qt-creator] Closing pinned files
|> |> >
|> |> > For a while now I’ve been meaning to implement
|> |> > https://bugreports.qt.io/browse/QTCREATORBUG-25964
|> |> > <https://bugreports.qt.io/browse/QTCREATORBUG-25964> to save
|> |myself
|> |> > the trouble of accidentally closing pinned files. Currently,
|> |> > pinned files are only immune from Close All, but closing via
|> |> > Ctrl+W, context menu, etc. will still close them without any prompt.
|> |> >
|> |> > I’m curious if anyone has opinions on potential solutions to this.
|> |> > Should we:
|> |> >
|> |> > - Ask the user if they want to close the pinned file, defaulting
|> |> > to “No”, and with the option to never ask again? To me, allowing
|> |> > the option to never ask again seems to defeat the purpose of
|> |> > pinning files; it’s too easy to accidentally close pinned files in the future.
|> |> >
|> |> > - Tell the user that pinned files cannot be closed, and that they
|> |> > have to be unpinned first. This option is perhaps less
|> |> > convenient, but in my experience, I almost never want to close
|> |> > pinned files, so it seems more foolproof. For those that dislike
|> |> > this, perhaps there could be a link to the settings to permanently
|disable it.
|> |> >
|> |> > What do you think?
|> |> >
|> |> >
|> |> > _______________________________________________
|> |> > Qt-creator mailing list
|> |> > Qt-creator at qt-project.org
|> |> > https://lists.qt-project.org/listinfo/qt-creator
|> |
|> |_______________________________________________
|> |Qt-creator mailing list
|> |Qt-creator at qt-project.org
|> |https://lists.qt-project.org/listinfo/qt-creator
|> _______________________________________________
|> Qt-creator mailing list
|> Qt-creator at qt-project.org
|> https://lists.qt-project.org/listinfo/qt-creator