[Releasing] Change I39f1b1fd in 4.8.2

[Nils Jeisecke]

Hi Robin,

thanks for the feedback.

I'm not sure how to implement a really meaningful unit test for this Mac OS
specific problem.
Maybe you could have a look at patch set 1 which tries to solve this on the
cocoa level.

But I guess this is the wrong list for further discussion anyway.

Nils

On Wed, Apr 25, 2012 at 10:28 AM, Robin Burchell <robin+qt at viroteck.net>wrote:

> Hi,
>
> 2012/4/25 Nils Jeisecke <njeisecke at saltation.de>:
> > I case it's not too late, would some consider
> > reviewing https://codereview.qt-project.org/#change,24075 for 4.8.2?
>
> As noted on the review, you're missing unit tests, which would
> personally make me wary of slipping this in without some pretty
> intensive testing at this stage. It may be too late for that.
>
> Your bug report notes that this also affects 4.7.4 and all 4.8
> releases so far, so I'd be inclined to let it go into 4.8.3 - which,
> given the past two releases, won't be far away.
>
> BR,
>
> Robin
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/releasing/attachments/20120425/158a948d/attachment.html>