[Releasing] Change I39f1b1fd in 4.8.2

[Turunen Tuukka]

Yes, for any change to be in a release, it has to go through the CI system into the 4.8 branch.

As has been discussed before, we are making the 4.8 patch release directly from 4.8 branch. So we do not cherry pick anything, getting a new fix in means we take all that are in by that point in time.

So for this particular item first thing is to get it into the 4.8 branch, after which we can evaluate if we should switch to different sha1 for the release being created (otherwise it will be in the next patch release).

Yours,

--
Tuukka Turunen
Director, Qt Commercial R&D
Digia Plc
Piippukatu 11, 40100 Jyväskylä, Finland

Visit us at: www.digia.com<applewebdata://7FB7E1CD-55A7-4FAD-B1A5-7721230C2E29/www.digia.com> or qt.digia.com<http://qt.digia.com/>


From: Nils Jeisecke <njeisecke at saltation.de<mailto:njeisecke at saltation.de>>
Date: Wed, 25 Apr 2012 10:56:14 +0200
To: Robin Burchell <robin+qt at viroteck.net<mailto:robin+qt at viroteck.net>>
Cc: <releasing at qt-project.org<mailto:releasing at qt-project.org>>
Subject: Re: [Releasing] Change I39f1b1fd in 4.8.2

Hi Robin,

thanks for the feedback.

I'm not sure how to implement a really meaningful unit test for this Mac OS specific problem.
Maybe you could have a look at patch set 1 which tries to solve this on the cocoa level.

But I guess this is the wrong list for further discussion anyway.

Nils

On Wed, Apr 25, 2012 at 10:28 AM, Robin Burchell <robin+qt at viroteck.net<mailto:robin+qt at viroteck.net>> wrote:
Hi,

2012/4/25 Nils Jeisecke <njeisecke at saltation.de<mailto:njeisecke at saltation.de>>:
> I case it's not too late, would some consider
> reviewing https://codereview.qt-project.org/#change,24075 for 4.8.2?

As noted on the review, you're missing unit tests, which would
personally make me wary of slipping this in without some pretty
intensive testing at this stage. It may be too late for that.

Your bug report notes that this also affects 4.7.4 and all 4.8
releases so far, so I'd be inclined to let it go into 4.8.3 - which,
given the past two releases, won't be far away.

BR,

Robin



_______________________________________________ Releasing mailing list Releasing at qt-project.org<mailto:Releasing at qt-project.org> http://lists.qt-project.org/mailman/listinfo/releasing
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/releasing/attachments/20120425/5c245ad9/attachment.html>