[Releasing] Package 2012-05-31 build failure in QtWebKit

[Simon Hausmann]

On Friday, June 01, 2012 10:33:00 AM ext Thiago Macieira wrote:
> On sexta-feira, 1 de junho de 2012 09.41.31, Thiago Macieira wrote:
> > On sexta-feira, 1 de junho de 2012 09.09.19, Simon Hausmann wrote:
> > > > Can't locate version.pm in @INC (@INC contains:
> > > Strange that your distro isn't shipping version.pm. I'll have a look and
> > > see  if webkitdirs.pm still actually needs version.pm - it might not
> > 
> > Oh, a distro thing? I can install that.
> > 
> > With the lowercase 'v', I assumed it was a WebKit module that wasn't found
> > due to some path mistake.
> 
> Here we go, after half an hour building:
> 
> In file included from /tmp/qt-everywhere-opensource-
> src-5.0.0/qtwebkit/Source/WebCore/plugins/qt/PluginViewQt.cpp:87:0:
> /tmp/qt-everywhere-opensource-
> src-5.0.0/qtbase/include/QtGui/QPlatformNativeInterface:4:4: error: #warning
> Header <QtGui/QPlatformNativeInterface> is deprecated. Please include
> <qpa/qplatformnativeinterface.h> instead. [-Werror=cpp]
> /tmp/qt-everywhere-opensource-
> src-5.0.0/qtbase/include/QtGui/QPlatformNativeInterface:8:42: fatal error:
> qpa/qplatformnativeinterface.h: No such file or directory
> cc1plus: all warnings being treated as errors

This btw was fixed in qt5.git last week, too.
 
> Please, please, PLEASE turn off -Werror. Enable it only if the user used the
> configure option -developer-build. Leaving it on for regular users means
> that changes to the toolchain, like a compiler upgrade or downgrade, but
> also changes to system headers, may cause new warnings to show up and,
> thus, break the build.

I agree, we shouldn't use it for non developer builds. I'll look into that.

For development I've found it to be a rather useful thing to have enabled 
though. People so easily introduce warnings and never bother to fix them, so 
having the CI system enforce -Werror on linux-g++ helps.

Simon
 
> The second error, though, is not webkit's fault. Since the webkit perl
> script ran the wrong make command, I don't know what the command-line was.