[Development] [Qt-creator] gerrit-speak

Samuel Rødal samuel.rodal at digia.com
Fri Dec 14 09:50:04 CET 2012

> There's a point though that a lot of people (including me) are using -1 for 'this requires more work', and -2 for 'the patch, or target branch is just wrong, please abandon'. So if the intention of the patch is fine in general, but contains some errors, I myself tend to give -1, though it should maybe be a -2. Anyway, I think everyone giving a -1 or -2 should put an explanation in the comments which explains things, so I haven't yet perceived this as a real issue.

Absolutely, a -1 or a -2 without an explanation is worthless anyhow.


More information about the Development mailing list