[Development] fixing name of QNetworkAccessManager::createRequest

Giuseppe D'Angelo dangelog at gmail.com
Fri Jan 13 14:00:08 CET 2012


On 13 January 2012 12:32, Mathias Hasselmann <mathias at openismus.com> wrote:
>> what about the slightly more garden-variety approach of deprecating
>> the old one and introducing a new method?
>
> Maybe we should check the premise of this discussion first.
> Does that method really have the wrong name? It is called
> "createRequest" and after all it causes creation of a network request.
> Now this network request is just an internal object, and not exposed to
> the API user. Instead the watchable reply object is returned in advance.

The problem is that it doesn't match the Qt namings for the relevant
classes... createRequest takes a QNetworkRequest (which is a
"description" of the request that should be made), starts making the
underlying network request as you described, but then also creates and
returns a reply (QNetworkReply). Bikeshedding?
-- 
Giuseppe D'Angelo



More information about the Development mailing list