[Development] New QUrl reviewing

[Thiago Macieira]

On sábado, 31 de março de 2012 18.14.50, Stephen Kelly wrote:
> On Friday, March 30, 2012 12:45:44 Thiago Macieira wrote:
> > On sexta-feira, 30 de março de 2012 17.00.15, Stephen Kelly wrote:
> > > On Thursday, March 29, 2012 23:31:38 Thiago Macieira wrote:
> > > > We really need the topic branch reviewing feature back in. It's no
> > > > fun
> > > > staging 19, 20, 20 and 21 changes...
> > > 
> > > Did you consider staging them a few commits at a time?
> > 
> > Yes. The tests might not pass. In fact, the very first commit had a test
> > failure which was fixed later on and I wasn't about to figure out what had
> > fixed it.
> > 
> > It's all or nothing. That's what the topic branch feature is for.
> 
> That means in the future anyone debugging a bug introduced in one of the
> patches will also get unrelated failures in the unit tests, or maybe won't
> be able to bisect.

Yes, then they skip it.

> Also definitely not ideal, but you're more likely to be debugging it in the
> future than me...

If I can, I try to make sure that each commit is testable on its own.

However, I will sacrifice testing for atomic changes. I don't like having big 
changes doing lots of things because it's hard to understand how certain 
changes came by.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
     Intel Sweden AB - Registration Number: 556189-6027
     Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20120331/d7340d9d/attachment.sig>