[Development] Status on QString's UTF-8 changes

Thiago Macieira thiago.macieira at intel.com
Mon May 7 07:30:51 CEST 2012

On quarta-feira, 2 de maio de 2012 16.26.42, Thiago Macieira wrote:
> The following two pending commit changes the QString 8-bit functions to use
> UTF-8, by *temporarily* changing fromAscii to mean fromUtf8, and toAscii to
> mean toUtf8.
> 	https://codereview.qt-project.org/24700
> 	https://codereview.qt-project.org/24701
> 	tests: https://codereview.qt-project.org/24702

They're in.

> They have been tested in qtbase and no regressions have been found. I do not
> believe they should cause regressions in other modules.
> I'm now testing a series of changes that change fromAscii to fromUtf8, as
> well as correct one or two encoding mistakes I think I've found. Since
> fromAscii == fromUtf8 at this point in the test, the change is technically
> a no-op and I expect no regressions at all. Those changes are done for the
> few places in the code where the data seemed to be non-Latin1 in origin, as
> well as QString itself.

Those are done.

> Next, I'll change all remaining fromAscii to fromLatin1 and toAscii to
> toLatin1. Since that's what those functions were before (still are right now
> in qtbase master), I also expect no regressions. Then I'll deprecate the
> Ascii functions.

Done, except for one change in qmake that is still not approved.

> Finally, probably starting two weeks from now when I'm back from the US,
> I'll start benchmarking and optimising the fromUtf8 function, as well as
> merging the many UTF-8 encoders and decoders in Qt (yes, we have more than
> one).

That's the next step.

QString's constructor is now UTF-8. The change has just been approved by the 

Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
     Intel Sweden AB - Registration Number: 556189-6027
     Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.qt-project.org/pipermail/development/attachments/20120506/e76cd7e1/attachment.sig>

More information about the Development mailing list