[Development] How to submit an approved patch?

[Girish Ramakrishnan]

On Mon, May 14, 2012 at 7:21 AM, Carl Schumann <schumann at fnal.gov> wrote:
> On 5/14/2012 9:15 AM, Jonas M. Gastal wrote:
>> On Monday 14 May 2012 09:11:20 Carl Schumann wrote:
>>> Qt developer community,
>>>
>>> I am a first timer at this process, but have now managed to get a change
>>> approved:
>>> https://codereview.qt-project.org/26041
>>> According to http://wiki.qt-project.org/Qt_Contribution_Guidelines I
>>> should now submit my patch.  I am looking for more detail on how to
>>> submit a patch please.  E.g., How do I tell if the branch and/or
>>> repository to which I am submitting has a CI system please?   How do I
>>> submit a patch to either the staging or target branch?   Is this
>>> something I do from the web interface?   Any guidance would be most
>>> appreciated.  Thanks in advance for any help.
>>>
>>> Sincerely,
>>> Carl Schumann
>>>
>>> _______________________________________________
>>> Development mailing list
>>> Development at qt-project.org
>>> http://lists.qt-project.org/mailman/listinfo/development
>> Carl,
>>
>> You choose the branch when you pushed your change to gerrit. Once it's been
>> aproved there, you need to bug however aproved it to stage the change. From
>> there it automaticaly goes through CI and if all works is merged into the
>> target branch.
>>
>> Gastal
> Gastal, Thanks.
>
> Quoting: http://wiki.qt-project.org/Qt_Contribution_Guidelines
>> Submit your patch. If your contribution satisfies the technical
>> requirements, then **you** or the Approver are able to submit the
>> patch into the staging branch, or directly into the target branch, if
>> there's no CI system on that particular branch and/or repository.
>
> So I was expecting to be able to stage the change myself.  So to
> confirm, only the Approver may stage the patch?  Thanks any clarification.
>

Any approver can stage the patch (for example, thiago staged your
patch even though lars approved it).

Girish