[Development] SIC: QAbstractPrintDialog & QAbstractPageSetupDialog

John Layt jlayt at kde.org
Sat May 19 18:41:18 CEST 2012


On Wednesday 16 May 2012 23:49:42 John Layt wrote:
> Actually removing the "abstract" base class is just a case of
> s/QAbstractPrintDialog/QPrintDialog and tweaking the constructors, as the
> class is not really abstract, the only virtual method is exec(), nothing
> else gets reimplemented in the platform specific QPrintDialog derived
> class, only new methods get added.

I've posted a quick proof of concept at https://codereview.qt-
project.org/#change,26596 which basically does the name replace and removes 
the obsolete api.  A real change would do more clean-ups, and would probably 
only deprecate the obsolete options api.

The page setup dialog is even simpler.

Cheers!

John.



More information about the Development mailing list