[Development] Some QIcon::fromTheme() enhancements

Olivier Goffart olivier at woboq.com
Fri Aug 23 07:50:56 CEST 2013


On Thursday 22 August 2013 22:18:54 Antti Kaijanmäki wrote:
> On 22.08.2013 21:51, Thiago Macieira wrote:
> > On quinta-feira, 22 de agosto de 2013 21:26:15, Antti Kaijanmäki wrote:
> >> I have patches (linked in the bug) to amend this, and I would like to
> >> get some feedback on them.
> > 
> > Hello Antti
> > 
> > If you can, please upload the patches to codereview.qt-project.org. It's
> > easier to discuss them there.
> 
> Either I was not clear enough or I have misunderstood something, but the
> links to the patches in codereview.qt-project.org are in that bug report. :)

Thanks for the patch, I will have a look.
However, the patches do not fix a regression, neither a P1 bug, so they should 
go to the 'dev' branch instead of the 'stable' branch.

-- 
Olivier

Woboq - Qt services and support - http://woboq.com - http://code.woboq.org



More information about the Development mailing list