[Development] #error for unreleased MSVC versions

Knoll Lars Lars.Knoll at digia.com
Thu Oct 24 17:40:15 CEST 2013



On 24/10/13 16:51, "Koehne Kai" <Kai.Koehne at digia.com> wrote:

>
>> -----Original Message-----
>> From: development-bounces+kai.koehne=digia.com at qt-project.org
>> [mailto:development-bounces+kai.koehne=digia.com at qt-project.org] On
>> Behalf Of Thiago Macieira
>> Sent: Thursday, October 24, 2013 4:39 PM
>> To: development at qt-project.org
>> Subject: Re: [Development] #error for unreleased MSVC versions
>> 
>> On quinta-feira, 24 de outubro de 2013 16:09:37, Yves Bailly wrote:
>> > While I understand the reasoning about binary compatibility, in my
>> > humble opinion such a drastic change should be at least deactivable,
>> > for example by adding a switch to "configure", something like
>> > "-ignore-binary-compatibility". This way older versions of Qt would
>> > still be compilable (assuming no other compile error).
>> 
>> As replied to André: to re-enable compilation, delete one line from
>> qcompilerdetection.h.
>
>Here's an idea to blend this with the discussions about our 'Tier'
>platforms: We implement this as a configure check , and hard code checks
>for our 'supported' platforms there . We do that not only for MSVC, but
>for other compilers too (for instance for MinGW from Mingw.org ;).
>Failing the check would bring a warning along the lines of:
>
>"
>You're trying to compile Qt with an unsupported toolchain/compiler. Qt
>might not compile, the generated binaries might be broken, or not be
>binary compatible with older builds.
>
>Exiting. Pass --unsupported-toolchain to overwrite this check.
>"

Please do this instead of adding the #error in qcompilerdetection. I don¹t
think it¹s a good idea that people have to have Qt headers to get it to
compile on a newer version of the compiler. Forcing people to acknowledge
the fact at configure time is a better approach.

Lars




More information about the Development mailing list