[Development] Upgrading the sources to C++11 keywords (Q_NULLPTR, etc.)

Olivier Goffart olivier at woboq.com
Wed Feb 11 10:56:29 CET 2015


On Wednesday 11 February 2015 10:49:31 Marc Mutz wrote:
> On Wednesday 11 February 2015 07:54:52 Hausmann Simon wrote:
> > I suppose that it is absolutely unlikely that we are going to find a
> > consensus on what is purely an aesthetic issue.
> > 
> > I for one am entirely with André and I do not like UPPERCASE macros in my
> > face unless I can avoid them. It's aesthetics and I suppose there is
> > little that will change that.
> > 
> > As approver I will approve code that uses Q_NULLPTR but I expect others
> > reviewing my code to respect my preference to use 0 until we can use
> > nullptr.
> 
> Apart from the claim that there is nothing technical in this discussion, I
> agree with the above. Respect the preference of the guy who codes. I like
> simple rules. This is one.

I prefer using curly braces for if even if there is only one line.
This is what the KDE coding style mandate, it makes diff smaller when you add 
or remove lines, and it helps preventing mistakes likes the "goto fail; goto 
fail;" one.
Am i going to be allowed to use curly braces?





More information about the Development mailing list