[Development] Compile errors, Qt configured with -qreal float

[Thiago Macieira]

On quarta-feira, 26 de outubro de 2016 17:40:52 PDT Sergio Martins wrote:
> On 2016-10-26 16:01, Thiago Macieira wrote:
> > On quarta-feira, 26 de outubro de 2016 10:18:49 PDT Ola Røer Thorsen
> > 
> > wrote:
> >> I'm getting compile errors building both Qt 5.6.2 and 5.8 beta from
> >> source
> >> when configuring Qt with -qreal float and building using g++ on Linux.
> >> The
> >> affected modules are Charts and Location.
> >> 
> >> https://bugreports.qt.io/browse/QTBUG-56715
> >> 
> >> I would think that this should be given a higher priority than P3. I
> >> initially reported this for 5.6.2 using a cross compile arm toolchain,
> >> but
> >> now I see it also affects 5.8 beta on the desktop.
> >> 
> >> If -qreal float is a supported configuration, shouldn't this have been
> >> caught in the CI system automatically?
> > 
> > We don't test every module with every configuration. It's just too many
> > permutations possible.
> > 
> > Thanks for reporting, those issues are easy to fix. The line in
> > 
> > question is:
> >             bottomRight.setLatitude(qMax(bottomRight.latitude(),
> >                                                  -85.05113));
> > 
> > To fix this, the literal number needs to be written as:
> > qreal(-85.05113).
> > There's also a qMin line right above with the same problem.
> 
> That's not enough and probably just 10% of the cost of the solution. One
> also needs to figure the contribution process and commit. The problem
> here is not technical, it's about inertia.

I diidn't mean that Ola should contribute the fix. I was merely pointing out 
the fix for whoever will have to fix the issue.

In any event, this change in qtbase will help too (5.8 only):
	https://codereview.qt-project.org/175025

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center