[Development] Undeprecating QString::null

[Konstantin Ritt]

changing the parameter's default value *is* binary compatible.


Regards,
Konstantin

2018-01-16 20:35 GMT+04:00 Jean-Michaël Celerier <
jeanmichael.celerier at gmail.com>:

> > The "just change" introduces a binary incompatibility - right ?
>
> I don't think it does: the QString is constructed on the caller's side
> anyways and your function is always passed a QString object;
> if you had an app that linked to qwt and didn't recompile it will just
> keep calling QString::null() from its side and pass the resulting object to
> your function.
>
> Best,
> Jean-Michaël
>
> On Tue, Jan 16, 2018 at 5:22 PM, Konstantin Tokarev <annulen at yandex.ru>
> wrote:
>
>>
>>
>> 16.01.2018, 19:18, "Uwe Rathmann" <uwe.rathmann at tigertal.de>:
>> > On Tue, 16 Jan 2018 16:47:57 +0100, Olivier Goffart wrote:
>> >
>> >>  Just change your code to use "= QString()", no #ifdef necessary.
>> >
>> > The "just change" introduces a binary incompatibility - right ?
>> >
>> > Please be aware, that Qwt is part of almost any Linux distro - according
>> > to sourceforge it has more than 1000 additional downloads every week
>> > since many years.
>> >
>> > All distro maintainers would not only have to upgrade the Qwt packages,
>> > but also all packages depending on it - users would have to rebuild.
>>
>> However, it seems like amount of reverse dependencies of Qwt is rather
>> moderate, e.g. in Ubuntu I see
>>
>>   libqwt6:i386
>>   zygrib
>>   simon
>>   qsapecng
>>   qgis
>>   nlkt
>>   libqwt-dev
>>   libqgis-gui2.0.1
>>
>>
>> >
>> > Considering the strict compatibility rules you have for Qt you will
>> > understand, that this is nothing I would like to do easily.
>> >
>> > But could you please comment on why this change is an improvement -
>> > beyond getting rid of 3-4 lines in qstring.h ?
>>
>> Because having redundancies in API is bad maybe?
>>
>> >
>> > Thanks,
>> > Uwe
>> >
>> > _______________________________________________
>> > Development mailing list
>> > Development at qt-project.org
>> > http://lists.qt-project.org/mailman/listinfo/development
>>
>> --
>> Regards,
>> Konstantin
>> _______________________________________________
>> Development mailing list
>> Development at qt-project.org
>> http://lists.qt-project.org/mailman/listinfo/development
>>
>
>
> _______________________________________________
> Development mailing list
> Development at qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20180116/aab5bcd8/attachment.html>