[Development] codereview, merge please

[Martin Koller]

On Freitag, 15. Februar 2019 11:08:18 CET Andy Shaw wrote:
> Since it has the +2 you can click on the "Merge patch 2 to staging" now, is that button showing up for you?

So now I did merge it to staging, but I got a "Qt CI Bot" mail stating that
"Continuous Integration: Failed"
https://testresults.qt.io/coin/integration/qt/qtbase/tasks/1550613219

I have no idea how a DBus test could be influenced by my commit.
Should I just try to merge again or what is the correct procedure ?

> 
> Andy
> 
> -----Opprinnelig melding-----
> Fra: Development <development-bounces at qt-project.org> på vegne av Martin Koller <kollix at aon.at>
> Dato: fredag 15. februar 2019 11:04
> Til: "development at qt-project.org" <development at qt-project.org>
> Emne: [Development] codereview, merge please
> 
>     Hi,
>     
>     I made a patch here
>     https://codereview.qt-project.org/#/c/249171/
>     
>     but it's still not merged.
>     Did I forget something ?
>     
>     -- 
>     Best regards/Schöne Grüße
>     
>     Martin
>     A: Because it breaks the logical sequence of discussion
>     Q: Why is top posting bad?
>     
>     ()  ascii ribbon campaign - against html e-mail 
>     /\                        - against proprietary attachments
>     
>     Geschenkideen, Accessoires, Seifen, Kulinarisches: www.lillehus.at
>     
>     
>     _______________________________________________
>     Development mailing list
>     Development at qt-project.org
>     https://lists.qt-project.org/listinfo/development
>     
> 
> 


-- 
Best regards/Schöne Grüße

Martin
A: Because it breaks the logical sequence of discussion
Q: Why is top posting bad?

()  ascii ribbon campaign - against html e-mail 
/\                        - against proprietary attachments

Geschenkideen, Accessoires, Seifen, Kulinarisches: www.lillehus.at