[Development] Code Review Process

Dmitriy Purgin dpurgin at gmail.com
Tue Jan 14 10:10:03 CET 2020

Hi all,

I'm afraid I did something incorrectly when submitting my first
contribution to the Qt project and I would love to get a feedback if I did
it wrong.

A week ago I created a patch adding an std::chrono overload to
QStateMachine::postDelayedEvent() and submitted it through gerrit to code
review [1] following the contribution guidelines [2], I pushed my code to
the dev branch as it is a safe choice for the new contributors, if I recall
correctly from the QWS19 panel discussion. I also added Thiago to the
reviewers because he is listed as the QtCore maintainer at [3], as well as
Marc and Lars because I see their names often in the QtCore patches. So I
got +1 from the Sanity Bot, and nothing has changed since then.

Is there something I've missed? Should I have created a ticket in Jira
first? Or should I have targeted the 5.15 branch?

I know that reviewers have a lot of other things to do and I don't want to
put pressure or something, I'm just wondering how long the review process
normally takes, and should I be already worried or not.

[1] https://codereview.qt-project.org/c/qt/qtbase/+/285825
[2] https://wiki.qt.io/Qt_Contribution_Guidelines
[3] https://wiki.qt.io/Maintainers

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.qt-project.org/pipermail/development/attachments/20200114/730af00b/attachment.html>

More information about the Development mailing list