[Development] Header review process: follow-up on comments

Fabian Kosmale fabian.kosmale at qt.io
Tue May 2 11:33:44 CEST 2023


while gerrit _didn't_ have support for it, that changed in 3.7. It needs 
to be manually enabled 
(https://www.gerritcodereview.com/3.7.html#mention-user-support), but 
maybe that would be a good way forward?


On 02.05.23 11:00, Volker Hilsheimer via Development wrote:
> With Qt 6.5, it’s been a struggle to get people to respond and follow-up to comments made during the header review process.
> Gerrit doesn’t really care about @user-style mentioning in comments, even though is seems that some people assume that it does. Creating JIRA tickets is the official way of doing it, but creating a ticket just to get someone’s attention to input (which might or might not require a change) seems heavy-handed. Ultimately, lots of people will be on cc or review of the respective header-review gerrit change, so everything becomes everyone’s problem.
> Maintainers have a special responsibility during header review, but esp with qtbase that is also a lot of people.
> What can we do to make this a better process that doesn’t end up with changes being made very late (with 6.5 we had some the day before the release candidate, IIRC)?
> Volker

Fabian Kosmale
Manager R&D

The Qt Company GmbH
Erich-Thilo-Str. 10
D-12489 Berlin
fabian.kosmale at qt.io
+49 1638686070

More information about the Development mailing list