[Qt-creator] gerrit ws-only

Frans Klaver fransklaver at gmail.com
Tue Nov 15 21:54:12 CET 2011


On Tue, 15 Nov 2011 19:59:19 +0100, Tom Deblauwe  
<Tom.Deblauwe at traficon.com> wrote:

> I'm trying to figure out what gerrit means with this error message of  
> the sanitize bot:
>
> - Mixing whitespace-only changes with other changes
>
> I have the problem that there are a bunch of foreach() statements in a  
> file. I made changes to this file, but not to the existing foreach()  
> statements. Then I submit, and I get a complaint about the fact that the  
> "foreach" keyword must be followed by a space. So I change this, and  
> then I get the mixing whitespace only error message. How do I solve it?

If gerrit supports it, go incremental. Make your change set consist of two  
commits; the first fixing the whitespace, the second the actual change.

> Also, I saw that no one is maintainer of the cmake support, and I'd like  
> to get some feedback on this patch I made. How do I do this?

I would notify people on the mailing list and put a link to the change  
into the mail.

Cheers,
Frans



More information about the Qt-creator mailing list