[Qt-creator] Preparing to contribute Boost.Build Plugin to Qt Creator

Mateusz Loskot mateusz at loskot.net
Thu Apr 16 10:49:26 CEST 2015

On 15 April 2015 at 10:47, Oswald Buddenhagen
<oswald.buddenhagen at theqtcompany.com> wrote:
> On Wed, Apr 15, 2015 at 10:15:40AM +0300, Orgad Shaneh wrote:
>> On Wed, Apr 15, 2015 at 9:58 AM, Mateusz Loskot <mateusz at loskot.net> wrote:
>> > The issue here is, that I know the current code will be rejected
>> > straight away due to Qt(Creator)-incompatible coding conventions
>> > used.  So, we need to port to Qt coding style and we will be working
>> > on it as a team.
>> >
>> It won't be rejected. Wip branches are exactly for that - submitting
>> changes that are unacceptable under regular terms, while the final
>> review will be done in a single squashed commit when the work on this
>> branch is done.
> it depends on how the involed parties want to work. it certainly would
> be possible to polish the "initial import" into a state that is
> acceptable in itself

I think, that's why I've been considering to collaborate outside
Gerrit, on GitHub,
during this initial stage. Once we are happy about the plugin
sources for the "initial import", then we would push to Gerrit.
That initial phase would be mostly about adjusting coding style.
I guess, if we chose to clean up the sources on GitHub first,
it wouldn't affect the following Gerrit workflow, so it should be fine.

> and build other self-contained changes on top.
> that tends to be unrealistic for big contributions by inexperienced
> developers, so a squash is typically unavoidable, but it comes with
> downsides as well (especially if it is team work, as work becomes not
> individually attributable any more).

Would the initial phase outlined above help to preserve the following
individual contributions?

> also, never forget that a gerrit review is a branch in itself.

That's another piece of information that helps me to grasp the whole machinery.

Best regards,
Mateusz  Loskot, http://mateusz.loskot.net

More information about the Qt-creator mailing list